[PATCH] Let -rpath work

[Rui Ueyama]

================
Comment at: lib/Driver/GnuLdDriver.cpp:294
@@ +293,3 @@
+      SmallVector<StringRef, 2> rpaths;
+      StringRef(inputArg->getValue()).split(rpaths, ":");
+      for (auto path : rpaths)
----------------
Do we really need to split the argument with ":"? The arguments will eventually be joined with ":" as separator, so splitting and joining is no-op. If we use each rpath value in the linker, splitting it would make sense, but we don't interpret rpath but just copies the value to program header, so that's not the case.

================
Comment at: lib/ReaderWriter/ELF/OutputELFWriter.h:175
@@ -163,1 +174,3 @@
+    _dynamicTable->addEntry(dyn);
+  }
   // The dynamic symbol table need to be sorted earlier because the hash
----------------
I'd make this a separate function for readability.


http://llvm-reviews.chandlerc.com/D1583