[PATCH] Cosmetic changes
Rui Ueyama
ruiu at google.com
Mon Sep 2 18:19:57 PDT 2013
Hi shankarke,
Not sure if this is in the coding style but this style seems pretty rare
in LLVM.
http://llvm-reviews.chandlerc.com/D1577
Files:
lib/Driver/CoreDriver.cpp
lib/Driver/GnuLdDriver.cpp
lib/Driver/WinLinkDriver.cpp
Index: lib/Driver/CoreDriver.cpp
===================================================================
--- lib/Driver/CoreDriver.cpp
+++ lib/Driver/CoreDriver.cpp
@@ -142,10 +142,10 @@
ctx.addPassNamed(inputArg->getValue());
break;
- case OPT_INPUT: {
+ case OPT_INPUT:
inputGraph->addInputElement(std::unique_ptr<InputElement>(
new COREFileNode(ctx, inputArg->getValue())));
- } break;
+ break;
default:
break;
Index: lib/Driver/GnuLdDriver.cpp
===================================================================
--- lib/Driver/GnuLdDriver.cpp
+++ lib/Driver/GnuLdDriver.cpp
@@ -266,7 +266,8 @@
(llvm::dyn_cast<ControlNode>)(controlNodeStack.top())
->processControlEnter();
inputGraph->addInputElement(std::move(controlStart));
- } break;
+ break;
+ }
case OPT_end_group:
(llvm::dyn_cast<ControlNode>)(controlNodeStack.top())
@@ -285,7 +286,8 @@
else
(llvm::dyn_cast<ControlNode>)(controlNodeStack.top())
->processInputElement(std::move(inputFile));
- } break;
+ break;
+ }
default:
break;
Index: lib/Driver/WinLinkDriver.cpp
===================================================================
--- lib/Driver/WinLinkDriver.cpp
+++ lib/Driver/WinLinkDriver.cpp
@@ -307,16 +307,18 @@
return true;
ctx.setStackReserve(reserve);
ctx.setStackCommit(commit);
- } break;
+ break;
+ }
case OPT_heap: {
// Parse /heap command line option
uint64_t reserve;
uint64_t commit = ctx.getHeapCommit();
if (parseMemoryOption(inputArg->getValue(), reserve, commit))
return true;
ctx.setHeapReserve(reserve);
ctx.setHeapCommit(commit);
- } break;
+ break;
+ }
case OPT_subsystem: {
// Parse /subsystem command line option. The form of /subsystem is
// "subsystem_name[,majorOSVersion[.minorOSVersion]]".
@@ -344,7 +346,8 @@
return true;
}
ctx.setSubsystem(subsystem);
- } break;
+ break;
+ }
case OPT_failifmismatch:
if (handleFailIfMismatchOption(inputArg->getValue(), failIfMismatchMap,
@@ -422,10 +425,10 @@
ctx.setOutputPath(ctx.allocateString(inputArg->getValue()));
break;
- case OPT_INPUT: {
+ case OPT_INPUT:
inputGraph.addInputElement(std::unique_ptr<InputElement>(
new PECOFFFileNode(ctx, inputArg->getValue())));
- } break;
+ break;
default:
break;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1577.1.patch
Type: text/x-patch
Size: 2536 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130902/a3e9e4c9/attachment.bin>
More information about the llvm-commits
mailing list