[lld] r189775 - Resolver: Do not use assert() to notify user input error.

Rui Ueyama ruiu at google.com
Mon Sep 2 17:50:22 PDT 2013


Author: ruiu
Date: Mon Sep  2 19:50:22 2013
New Revision: 189775

URL: http://llvm.org/viewvc/llvm-project?rev=189775&view=rev
Log:
Resolver: Do not use assert() to notify user input error.

Modified:
    lld/trunk/lib/Core/Resolver.cpp

Modified: lld/trunk/lib/Core/Resolver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/Resolver.cpp?rev=189775&r1=189774&r2=189775&view=diff
==============================================================================
--- lld/trunk/lib/Core/Resolver.cpp (original)
+++ lld/trunk/lib/Core/Resolver.cpp Mon Sep  2 19:50:22 2013
@@ -293,7 +293,11 @@ void Resolver::deadStripOptimize() {
   // Or, use list of names that are dead stip roots.
   for (const StringRef &name : _context.deadStripRoots()) {
     const Atom *symAtom = _symbolTable.findByName(name);
-    assert(symAtom->definition() != Atom::definitionUndefined);
+    if (symAtom->definition() == Atom::definitionUndefined) {
+      llvm::errs() << "Dead strip root '" << symAtom->name()
+                   << "' is not defined\n";
+      return;
+    }
     _deadStripRoots.insert(symAtom);
   }
 





More information about the llvm-commits mailing list