[llvm] r189704 - Remove the suggestion to not duplicate comments in header and

Chris Lattner clattner at apple.com
Sun Sep 1 08:49:32 PDT 2013


On Aug 31, 2013, at 9:12 AM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> > > Actually it did:
> > > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120910/150633.html
> >
> > Ok, it looks like all the discussion was in favor of this never being added to CodingStandards :-)
> 
> Not quite sure where you got that idea, though I'll admit the web archive isn't the best ui for reading things (but easiest way to reference it, searching your own email archive tends to be the more effective way to read the whole thread
> 
That thread seems to conclude pretty clearly that removing the copy is a bad idea.

> Andrew conceded to the patch later in the thread and eventually chandler signed off on it.
> 
> 
That thread also doesn't include that, though I admit that the webarchive isn't the easiest to navigate.

> This patch was appropriately pre-commit reviewed with discussion and disagreement, reverting/undoing it outright seems somewhat poor form.
> 
I'm fine with reverting it while we discuss, I didn't realize it was reviewed and approved.  It looked like it was a small paragraph that snuck in with a bigger (and great!) enhancement to the docs.

I'll revert it for now.

-Chris

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130901/6c52478a/attachment.html>


More information about the llvm-commits mailing list