[llvm] r189704 - Remove the suggestion to not duplicate comments in header and

[David Blaikie]

On Aug 30, 2013 5:55 PM, "Chris Lattner" <clattner at apple.com> wrote:
>
>
> On Aug 30, 2013, at 4:41 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
> > On Fri, Aug 30, 2013 at 4:34 PM, Chris Lattner <clattner at apple.com>
wrote:
> >> On Aug 30, 2013, at 4:24 PM, Benjamin Kramer <benny.kra at gmail.com>
wrote:
> >>> On 31.08.2013, at 01:06, Chris Lattner <sabre at nondot.org> wrote:
> >>>
> >>>> Author: lattner
> >>>> Date: Fri Aug 30 18:06:20 2013
> >>>> New Revision: 189704
> >>>>
> >>>> URL: http://llvm.org/viewvc/llvm-project?rev=189704&view=rev
> >>>> Log:
> >>>> Remove the suggestion to not duplicate comments in header and
> >>>> implementation files.  While doc generation systems don't need this,
> >>>> humans do benefit from it.  Not everyone reads all code through
doxygen.
> >>>
> >>> I disagree.
> >>
> >> I expected this to start a discussion… this is good because the
discussion never happened when gribozavr "Document current Doxygen use
practices in Coding Standards" in r166378.
> >
> > Actually it did:
> >
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120910/150633.html
>
> Ok, it looks like all the discussion was in favor of this never being
added to CodingStandards :-)

Not quite sure where you got that idea, though I'll admit the web archive
isn't the best ui for reading things (but easiest way to reference it,
searching your own email archive tends to be the more effective way to read
the whole thread)

Andrew conceded to the patch later in the thread and eventually chandler
signed off on it.

This patch was appropriately pre-commit reviewed with discussion and
disagreement, reverting/undoing it outright seems somewhat poor form.

(Not to say that there's no room for further discussion, and I realize,
while Dmitry mentioned you in the email, he didn't actually cc you, so it
can be easy for things to get lost in the masses of email)

>
> -Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130831/d335b916/attachment.html>