[llvm] r189642 - Replace LiveInterval::killedAt with isKilledAtInstr.

Jakob Stoklund Olesen stoklund at 2pi.dk
Fri Aug 30 10:47:07 PDT 2013


On Aug 30, 2013, at 10:43 AM, Andrew Trick <atrick at apple.com> wrote:

> 
> On Aug 30, 2013, at 9:26 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
> 
>> 
>> On Aug 29, 2013, at 9:31 PM, Andrew Trick <atrick at apple.com> wrote:
>> 
>>> Author: atrick
>>> Date: Thu Aug 29 23:31:01 2013
>>> New Revision: 189642
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=189642&view=rev
>>> Log:
>>> Replace LiveInterval::killedAt with isKilledAtInstr.
>>> 
>>> Return true for LRGs that end at EarlyClobber or Register slots.
>> 
>> Could you use LiveRangeQuery::isKill() instead?
> 
> Yes of course! As long as I can change the call in LiveRangeEdit and remove the API, which looked buggy to me…

Yep. LGTM.

Thanks,
/jakob





More information about the llvm-commits mailing list