[PATCH] Move generic isPrint and columnWidth implementations to a separate header/source to allow using both generic and system-dependent versions on win32.

Alexander Kornienko alexfh at google.com
Fri Aug 30 10:11:51 PDT 2013


alexfh added you to the CC list for the revision "Move generic isPrint and columnWidth implementations to a separate header/source to allow using both generic and system-dependent versions on win32.".

Hi jordan_rose,

This is needed so we can use generic columnWidthUTF8 in clang-format on
win32 simultaneously with a separate system-dependent implementations of
isPrint/columnWidth in TextDiagnostic.cpp to avoid attempts to print Unicode
characters using narrow-character interfaces (which is not supported on Windows,
and we'll have to figure out how to handle this).

http://llvm-reviews.chandlerc.com/D1559

Files:
  include/llvm/Support/Unicode.h
  lib/Support/CMakeLists.txt
  lib/Support/Locale.cpp
  lib/Support/LocaleGeneric.inc
  lib/Support/LocaleWindows.inc
  lib/Support/LocaleXlocale.inc
  lib/Support/Unicode.cpp
  unittests/Support/CMakeLists.txt
  unittests/Support/LocaleTest.cpp
  unittests/Support/UnicodeTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1559.4.patch
Type: text/x-patch
Size: 42005 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130830/b81ad0e4/attachment.bin>


More information about the llvm-commits mailing list