[PATCH] [RFC] Deprecated feature in TableGen
Jim Grosbach
grosbach at apple.com
Wed Aug 28 13:20:59 PDT 2013
Hi Joey,
With the multiple patches, I’m not completely clear on the state of things, so apologies if this is
I love the idea of being able to mark instructions (and aliases) as deprecated, but I’m not sure the mechanism of a custom comment handler is the right way to do it. We really want an assembler-time warning diagnostic when a deprecated instruction is used, for example. AFAICT, this implementation doesn’t support that and is tailored mainly for the disassembler use case, which quite honestly is much less interesting, IMO.
That is, I’d like something more completely TableGen’erated rather than the hard-coded isDeprecated() function in the target’s asmparser class.
What do you think?
-Jim
On Aug 28, 2013, at 8:34 AM, Joey Gouly <joey.gouly at arm.com> wrote:
> Forgot to rename this method on both sides.
>
> http://llvm-reviews.chandlerc.com/D1399
>
> CHANGE SINCE LAST DIFF
> http://llvm-reviews.chandlerc.com/D1399?vs=3866&id=3867#toc
>
> Files:
> include/llvm/MC/MCInstPrinter.h
> include/llvm/MC/MCInstrDesc.h
> include/llvm/Target/Target.td
> lib/Target/ARM/ARMInstrInfo.td
> lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp
> lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp
> test/MC/ARM/deprecated-v8.s
> utils/TableGen/CodeGenInstruction.cpp
> utils/TableGen/CodeGenInstruction.h
> utils/TableGen/InstrInfoEmitter.cpp
> <D1399.3.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list