[llvm] r189456 - Fix use of uninitialized value added in r189400 (found by MemorySanitizer)

[Alexey Samsonov]

Author: samsonov
Date: Wed Aug 28 03:30:47 2013
New Revision: 189456

URL: http://llvm.org/viewvc/llvm-project?rev=189456&view=rev
Log:
Fix use of uninitialized value added in r189400 (found by MemorySanitizer)

Modified:
    llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCMCExpr.cpp

Modified: llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCMCExpr.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCMCExpr.cpp?rev=189456&r1=189455&r2=189456&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCMCExpr.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCMCExpr.cpp Wed Aug 28 03:30:47 2013
@@ -54,7 +54,7 @@ PPCMCExpr::EvaluateAsRelocatableImpl(MCV
                                      const MCAsmLayout *Layout) const {
   MCValue Value;
 
-  if (Layout && !getSubExpr()->EvaluateAsRelocatable(Value, *Layout))
+  if (!Layout || !getSubExpr()->EvaluateAsRelocatable(Value, *Layout))
     return false;
 
   if (Value.isAbsolute()) {
@@ -85,7 +85,7 @@ PPCMCExpr::EvaluateAsRelocatableImpl(MCV
         break;
     }
     Res = MCValue::get(Result);
-  } else if (Layout) {
+  } else {
     MCContext &Context = Layout->getAssembler().getContext();
     const MCSymbolRefExpr *Sym = Value.getSymA();
     MCSymbolRefExpr::VariantKind Modifier = Sym->getKind();
@@ -118,8 +118,7 @@ PPCMCExpr::EvaluateAsRelocatableImpl(MCV
     }
     Sym = MCSymbolRefExpr::Create(&Sym->getSymbol(), Modifier, Context);
     Res = MCValue::get(Sym, Value.getSymB(), Value.getConstant());
-  } else
-    return false;
+  }
 
   return true;
 }