[compiler-rt] r189356 - Properly generate lists of exported symbols for sanitizer runtimes

Alexey Samsonov samsonov at google.com
Wed Aug 28 01:09:41 PDT 2013


On Tue, Aug 27, 2013 at 11:46 PM, Reid Kleckner <rnk at google.com> wrote:

> On Tue, Aug 27, 2013 at 12:17 PM, Alexey Samsonov <samsonov at google.com>wrote:
>
>>
>> On Tue, Aug 27, 2013 at 10:37 PM, Hans Wennborg <hans at chromium.org>wrote:
>>
>>> Is there any way we can make this work in the MSVC build too?
>>>
>>
>> Hm... I don't know if we need this for Windows/MSVC - what is the link
>> strategy for -fsanitize=foo
>> flag there (do we also link sanitizer runtimes into executables, but not
>> into dll's and therfore have to
>> export all the necessary symbols?)
>>
>
> The sanitizer runtimes are linked into the main executable and are
> annotated with dllexport, and there is a separate dll of thunks that uses
> GetProcAddress to route the call to the main executable.  Timur would know
> more.
>
> I think we can just put most of this symbol logic behind 'if (UNIX)'.
>


Yeah, I've submitted r189454 for that.

-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130828/02465e70/attachment.html>


More information about the llvm-commits mailing list