[PATCH] Enable vararg support for intrinsics

Juergen Ributzka juergen at apple.com
Tue Aug 27 15:33:55 PDT 2013


Hi Rafael,

thanks for looking at the patch.

On Aug 27, 2013, at 2:09 PM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:

> Which intrinsic do you want to use this for?
> 
> Please clang-format the patch. Please also include a test of the
> verifier changes.

Lang is working on a new intrinsic that would require vararg support, so it will be used soon. I will add a test case for the verifier, but it will be limited for now. I can only verify the changes against existing intrinsics and they are not varargs. Once Lang adds his new intrinsic I can extend the verifier test case.

> 
> +/// VerifyIntrinsicIsVarArg - Verify if the intrinsic has variable arguments.
> 
> Please don't repeat the name of the function. Starting it with a
> lowercase letter would probably also be better.
> 

I was following the coding/commenting style of the surrounding code. Do you still want me to change it in that case?

> 
> On 26 August 2013 16:28, Juergen Ributzka <juergen at apple.com> wrote:
>> Hi @ll,
>> 
>> this small patch enables vararg support for intrinsic.
>> 
>> Cheers,
>> Juergen
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 





More information about the llvm-commits mailing list