MC parser and PPC variants on constants

[Rafael Espíndola]

+ virtual const MCExpr *ApplyModifierToExpr(const MCExpr *E,

lowercase please.

+ const MCExpr *newE

should be NewE


Can you add a test with the error case that Ulrich suggested
(123 at got)? LGTM with these changes.


On 19 August 2013 16:22, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
> On Sat, Jul 13, 2013 at 08:10:56PM +0200, Joerg Sonnenberger wrote:
>> PowerPC assembler supports expressions like "1234 at l". This doesn't with
>> MC right now, because the constant expression never reaches the target
>> layer. I wonder if it is really that useful to refactor this ATM,
>> especially since it likely makes sense to share the variant codes at
>> some point as many RISC platforms have similar needs in this area.
>
> Third version, now much cleaner.
>
> Joerg
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>