[PATCH] [dfsan] Add custom function for pthread_create.
Evgeniy Stepanov
eugenis at google.com
Tue Aug 27 01:45:24 PDT 2013
================
Comment at: lib/dfsan/dfsan_custom.cc:285
@@ +284,3 @@
+ free(p);
+ dfsan_label ret_label;
+ return pci.start_routine_trampoline(pci.start_routine, pci.arg, 0,
----------------
I'm slightly confused. This would be the label for the thread return value, right? Don't you need to keep it somewhere for pthread_join()?
================
Comment at: lib/dfsan/lit_tests/custom.c:138
@@ +137,3 @@
+ pthread_join(pt, &cbrv);
+ assert(cbrv == (void *)2);
+
----------------
You are not testing any label-passing behavior of pthread_create() at all.
http://llvm-reviews.chandlerc.com/D1504
More information about the llvm-commits
mailing list