[PATCH] compiler-rt, cmake: make the asan runtime build on windows

Hans Wennborg hans at chromium.org
Mon Aug 26 18:25:01 PDT 2013


  > Looks fine to me, but Timur is the expert here.

  Thanks. I think we can land this now, it basically fixes the build on MSVC, and then Timur can advise on any flags that need tweaking etc.


================
Comment at: lib/asan/CMakeLists.txt:109
@@ +108,3 @@
+
+    if (WIN32)
+      add_compiler_rt_static_runtime(clang_rt.asan_dll_thunk-${arch} ${arch}
----------------
Reid Kleckner wrote:
> Yep, makes sense to be win32 here instead of msvc.
Oops, I actually missed this one :) Yeah, I guess it makes sense, but I'll change CFLAGS below to use -DASAN_DLL_THUNK instead of the /D variant.


http://llvm-reviews.chandlerc.com/D1525



More information about the llvm-commits mailing list