[llvm] r189299 - Remove an over-zealous assertion. A pointer type could be illegal if the target is prepared to custom-legalize pointer operands. This assertion was evaluated before the target would have a chance to do so, making it impossible.

Owen Anderson resistor at mac.com
Mon Aug 26 17:28:23 PDT 2013


Author: resistor
Date: Mon Aug 26 19:28:23 2013
New Revision: 189299

URL: http://llvm.org/viewvc/llvm-project?rev=189299&view=rev
Log:
Remove an over-zealous assertion.  A pointer type could be illegal if the target is prepared to custom-legalize pointer operands.  This assertion was evaluated before the target would have a chance to do so, making it impossible.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypesGeneric.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypesGeneric.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypesGeneric.cpp?rev=189299&r1=189298&r2=189299&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypesGeneric.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypesGeneric.cpp Mon Aug 26 19:28:23 2013
@@ -455,7 +455,6 @@ SDValue DAGTypeLegalizer::ExpandOp_Norma
 
   Ptr = DAG.getNode(ISD::ADD, dl, Ptr.getValueType(), Ptr,
                     DAG.getConstant(IncrementSize, Ptr.getValueType()));
-  assert(isTypeLegal(Ptr.getValueType()) && "Pointers must be legal!");
   Hi = DAG.getStore(Chain, dl, Hi, Ptr,
                     St->getPointerInfo().getWithOffset(IncrementSize),
                     isVolatile, isNonTemporal,





More information about the llvm-commits mailing list