[llvm] r189161 - Start to add the builtind to the mips16 exclusion lists for fp.

reed kotler rkotler at mips.com
Sat Aug 24 11:15:35 PDT 2013


I know what this is now.

It's a weird BSD issue and I how to fix it.

I will resubmit the test later  and patch later.

The test needs to have something added to the llc command line.

On 08/24/2013 10:57 AM, Shuxin Yang wrote:
> Revert in 189176.
>
> Don't get me wrong. I serve as almighty Czar for 2w.
> One of my duty is to revert problematic change if it stay in 
> repository for quite a while.
>
> On 8/23/13 6:24 PM, Reed Kotler wrote:
>> Author: rkotler
>> Date: Fri Aug 23 20:24:44 2013
>> New Revision: 189161
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=189161&view=rev
>> Log:
>> Start to add the builtind to the mips16 exclusion lists for fp.
>> I need to add the rest of these to the list or else to delay putting
>> out the actual stub until later in code generation when I know if
>> the external function ever got emitted.
>>
>>
>> Added:
>>      llvm/trunk/test/CodeGen/Mips/powif64_16.ll
>> Modified:
>>      llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp
>>
>> Modified: llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp
>> URL: 
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp?rev=189161&r1=189160&r2=189161&view=diff
>> ============================================================================== 
>>
>> --- llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp (original)
>> +++ llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp Fri Aug 23 
>> 20:24:44 2013
>> @@ -325,7 +325,7 @@ static void assureFPCallStub(Function &F
>>   // Functions that are inline intrinsics don't need helpers.
>>   //
>>   static const char *IntrinsicInline[] =
>> -  {"fabs"};
>> +  {"fabs", "llvm.powi.f64"};
>>     static bool isIntrinsicInline(Function *F) {
>>     return std::binary_search(
>>
>> Added: llvm/trunk/test/CodeGen/Mips/powif64_16.ll
>> URL: 
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Mips/powif64_16.ll?rev=189161&view=auto
>> ============================================================================== 
>>
>> --- llvm/trunk/test/CodeGen/Mips/powif64_16.ll (added)
>> +++ llvm/trunk/test/CodeGen/Mips/powif64_16.ll Fri Aug 23 20:24:44 2013
>> @@ -0,0 +1,28 @@
>> +; RUN: llc -march=mipsel -mcpu=mips16 -mips16-hard-float -soft-float 
>> -relocation-model=static < %s | FileCheck %s
>> +
>> + at x = global double 4.500000e+00, align 8
>> + at i = global i32 4, align 4
>> + at y = common global double 0.000000e+00, align 8
>> +
>> +; Function Attrs: nounwind optsize
>> +define i32 @main() #0 {
>> +entry:
>> +  %0 = load double* @x, align 8, !tbaa !0
>> +  %1 = load i32* @i, align 4, !tbaa !3
>> +  %2 = tail call double @llvm.powi.f64(double %0, i32 %1)
>> +; CHECK-NOT: .ent    __call_stub_fp_llvm.powi.f64
>> +; CHECK-NOT: {{.*}} jal llvm.powi.f64
>> +  store double %2, double* @y, align 8, !tbaa !0
>> +  ret i32 0
>> +}
>> +
>> +; Function Attrs: nounwind readonly
>> +declare double @llvm.powi.f64(double, i32) #1
>> +
>> +attributes #0 = { nounwind optsize "less-precise-fpmad"="false" 
>> "no-frame-pointer-elim"="true" 
>> "no-frame-pointer-elim-non-leaf"="true" "no-infs-fp-math"="false" 
>> "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" 
>> "unsafe-fp-math"="false" "use-soft-float"="true" }
>> +attributes #1 = { nounwind readonly }
>> +
>> +!0 = metadata !{metadata !"double", metadata !1}
>> +!1 = metadata !{metadata !"omnipotent char", metadata !2}
>> +!2 = metadata !{metadata !"Simple C/C++ TBAA"}
>> +!3 = metadata !{metadata !"int", metadata !1}
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>





More information about the llvm-commits mailing list