[PATCH] Vectorize starting from insertelements building a vector

Matt Arsenault arsenm2 at gmail.com
Fri Aug 23 20:25:31 PDT 2013


On Aug 22, 2013, at 23:02 , Nadav Rotem <nrotem at apple.com> wrote:

> Hi Matt, 
> 
> Thanks for catching this bug. I think that there are a few moth paths that call get Gather().


> Do you think that we should change the insert point in the Gather() call itself ?

No. Most of the other callers of Gather take care to set the insert point themselves, it's just that one and one other that don't.

The other one is in the ExtractElement case of vectorizeTree(TreeEntry *E). I haven't been able to come up with a case that actually reaches there. I'm not sure it's even reachable, since I think everything CanReuseExtract checks earlier sets the NeedToGather causing it to use the first one.



More information about the llvm-commits mailing list