[PATCH] Complete r184924 by changing the LLVM_INCLUDE_TOOL variable type

Edoardo P. ed0.88.prez at gmail.com
Fri Aug 23 15:32:39 PDT 2013


ping


2013/8/10 Edoardo P. <ed0.88.prez at gmail.com>

> Hi.
> I noticed that in llvm revision 184924 it was added the option
> 'bootstrap-only' to 'LLVM_INCLUDE_TOOL', but it is a BOOL type, so when you
> try to change the settings with cmake-gui, it resets the
> 'LLVM_INCLUDE_TOOL' to 'ON', messing with the configuration.
>
> This patch changes the 'LLVM_INCLUDE_TOOL' type to STRING and made a check
> which fatal exit if the given value to 'LLVM_INCLUDE_TOOL' is different
> from 'ON', 'OFF' and 'bootstrap-only', in order to prevent weird behavior
> in cmake configuration.
>
> Probably it requires an user change to CMakeCache.txt in order to replace
> 'LLVM_INCLUDE_TOOL:BOOL' with 'LLVM_INCLUDE_TOOL:STRING', but it should be
> okay, I hope.
>
> In this patch I changed the docs as well (I hope I did not use wrong
> syntax...).
>
> Edward-san
> --
> Mathematics is the language with which God has written the universe.
> (Galilei)
>



-- 
Mathematics is the language with which God has written the universe.
(Galilei)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130824/fbf97033/attachment.html>


More information about the llvm-commits mailing list