[PATCH] [lld][WinLinkDriver]Add support for /dynamicbase

Rui Ueyama ruiu at google.com
Fri Aug 23 15:13:24 PDT 2013


  LGTM with the following style fixes.


================
Comment at: lib/Driver/WinLinkDriver.cpp:367
@@ +366,3 @@
+      ctx.setDynamicBaseEnabled(false);
+      
+      break;
----------------
nit: remove this line.

================
Comment at: test/pecoff/dynamicbase.test:22
@@ +21,2 @@
+
+DYNAMIC_AND_FIXED: /dynamicbase must not be specified with /fixed
----------------
"-" seems to be preferred over "_" in tests for lld.


http://llvm-reviews.chandlerc.com/D1495



More information about the llvm-commits mailing list