[PATCH] Vectorize starting from insertelements building a vector

[Nadav Rotem]

Hi Matt, 

Thanks for catching this bug. I think that there are a few moth paths that call get Gather(). Do you think that we should change the insert point in the Gather() call itself ?

Thanks,
Nadav

On Aug 22, 2013, at 2:13 PM, Matt Arsenault <Matthew.Arsenault at amd.com> wrote:

>  I found a problem with this when the insertelements only partially build the vector. The Gather would end up inserting new insertelements at the start of the block before the extract elements producing the scalars, and the function verify would fail.
> 
>  I've changed the insert point to be after all the scalars in the place it happened, but I'm not sure this is the right place to fix this since there are other places that use Gather.
> 
> Hi nadav,
> 
> http://llvm-reviews.chandlerc.com/D1471
> 
> CHANGE SINCE LAST DIFF
>  http://llvm-reviews.chandlerc.com/D1471?vs=3659&id=3681#toc
> 
> Files:
>  lib/Transforms/Vectorize/SLPVectorizer.cpp
>  test/Transforms/SLPVectorizer/X86/insert-element-build-vector.ll
> <D1471.4.patch>