[PATCH][Clang Driver] Driver::IsUsingLTO no longer return true when seeing -emit-llvm

Eric Christopher echristo at gmail.com
Thu Aug 22 12:50:43 PDT 2013


On Thu, Aug 22, 2013 at 12:28 PM, Shuxin Yang <shuxin.llvm at gmail.com> wrote:
>
> On 8/22/13 10:34 AM, Eric Christopher wrote:
>>
>>
>> Right. My comment on this change is, in essence, that people have
>> depended upon the fact that -flto does what you want -emit-llvm to do
>> for that compile line for a while. I don't think it's necessarily
>> right, but that you're going to be breaking current use.
>>
>> -eric
>
>
> I saw one such use in clang's testing suite. I have already fixed the
> problem.
> I think in general we should avoid "clang -emit-llvm a.c" without -S or -c,
> as it is bit confusing.

I've seen it in much wider use which is why I bring it up.

Also if we don't think -emit-llvm should be used without -S or -c then
we should have the clang driver reject that set of options.

-eric



More information about the llvm-commits mailing list