[llvm] r188872 - MC CFG: uint64_t -> size_t for vector size.

Chandler Carruth chandlerc at google.com
Wed Aug 21 01:29:13 PDT 2013


On Wed, Aug 21, 2013 at 1:25 AM, Ahmed Bougacha <ahmed.bougacha at gmail.com>wrote:

> On Wed, Aug 21, 2013 at 1:19 AM, Chandler Carruth <chandlerc at google.com>
> wrote:
> >
> > On Wed, Aug 21, 2013 at 1:18 AM, Chandler Carruth <chandlerc at google.com>
> > wrote:
> >>
> >> econdly, it makes build bots useless at tell you which commit broke
> >> something and allowing fine grained rollbacks.
> >
> >
> > Notably, one of your patches broke a bunch of build bots.
>
> Hmm, I'm missing this one, link please?
>

http://bb.pgr.jp/builders/ninja-clang-i686-msc17-R/builds/4129

Of course, half the patches didn't fit into that *huge* list for this
build, so there is another build already queued up. It will take some time
for it to finish and validate that a later commit fixed the prior commit.

However, I didn't even see a mention in a commit that one fixes a build
break in the other, so all of this is really confusing to anyone working
while you pushed that ends up checked out half way through the stream.


>
> > Please fix these
> > *very quickly* or I will roll back the entire lot of them because it is
> just
> > too disruptive to do this to other developers. Please don't ever commit
> like
> > this again. =/
>
> Terribly sorry, more in a bit.
>
> -- Ahmed
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130821/567c6d46/attachment.html>


More information about the llvm-commits mailing list