[llvm] r188872 - MC CFG: uint64_t -> size_t for vector size.

[Chandler Carruth]

Ahmed, first please don't build up such a large bank of commits and push
them all at once.

This first causes significant load on the reviewers that is hard to predict
and absorb. Secondly, it makes build bots useless at tell you which commit
broke something and allowing fine grained rollbacks.

Please mail and commit a patch as soon as it is ready / approved.


Second, while this patch is clearly trivial, and I saw that the first last
of this long chain of patches introduced some testing facilities, *please*
introduce the test harness *first*, and then have incremental tests
attached to each commit so reviewers can see what has been fixed.

Finally, it doesn't look like any of this series really got reviewed before
committing. The last review I see with anything to do with MC CFG
construction was back in May, and you seemed to think pre-commit review was
appropriate there, so I don't know what some of these (not this one, I just
really don't want to write you N different emails with feedback) didn't
need review first.

-Chandler



On Wed, Aug 21, 2013 at 12:27 AM, Ahmed Bougacha
<ahmed.bougacha at gmail.com>wrote:

> Author: ab
> Date: Wed Aug 21 02:27:44 2013
> New Revision: 188872
>
> URL: http://llvm.org/viewvc/llvm-project?rev=188872&view=rev
> Log:
> MC CFG: uint64_t -> size_t for vector size.
>
> Modified:
>     llvm/trunk/include/llvm/MC/MCAtom.h
>
> Modified: llvm/trunk/include/llvm/MC/MCAtom.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCAtom.h?rev=188872&r1=188871&r2=188872&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/MC/MCAtom.h (original)
> +++ llvm/trunk/include/llvm/MC/MCAtom.h Wed Aug 21 02:27:44 2013
> @@ -139,7 +139,7 @@ public:
>
>    const MCDecodedInst &back() const { return Insts.back(); }
>    const MCDecodedInst &at(size_t n) const { return Insts.at(n); }
> -  uint64_t size() const { return Insts.size(); }
> +  size_t size() const { return Insts.size(); }
>    /// @}
>
>    /// \name Atom type specific split/truncate logic.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130821/70f6ce08/attachment.html>