[PATCH] CMake: Automatically pick up subdirectories in llvm/tools as 'external projects' if they contain a 'CMakeLists.txt' file

[Argyrios Kyrtzidis]

On Aug 20, 2013, at 5:27 PM, Michael Gottesman <mgottesman at apple.com> wrote:

> Hey Argyrios.
> 
> I like the patch, but I think that the name of the variable LLVM_TOOL_SUBDIRS is misleading since you are appending to it subdirectories that are going to explicitly not be included as well as those that will be. I can easily see a tired befuddled programmer getting confused about the meaning of said variable since it violates the expectations that every directory in that variable will include a tool that will be built (I was confused and I am only slightly tired/befuddled).
> 
> The real thing you are using said variable for is to act as a signal to add_llvm_implicit_external_projects that it should ignore said subdirectory. Perhaps something like LLVM_IMPLICIT_PROJECT_IGNORE? Even though that name sucks, it at least makes it absolutely clear about the purpose of the variable.

Yes, that is better, thanks!

Attached new patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: auto-external-proj2.diff
Type: application/octet-stream
Size: 5321 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130820/2eed6f23/attachment.obj>