[llvm] r188807 - Marking MCJIT PIC tests as XFAIL on arm

Kaylor, Andrew andrew.kaylor at intel.com
Tue Aug 20 09:50:32 PDT 2013


Hi David,

I guess I was a bit hasty in making that change.  In those two cases I actually ended up with arm in the XFAIL list twice.

That list gets iterated through a Python and each entry is compared against the target triple so order or even duplication shouldn't matter to the script, but if it's more convenient for you to have them together that's good enough reason to do it that way.

This should be covered by r188812.

Thanks,
Andy

-----Original Message-----
From: David Tweed [mailto:david.tweed at arm.com] 
Sent: Tuesday, August 20, 2013 9:40 AM
To: Kaylor, Andrew; llvm-commits at cs.uiuc.edu
Subject: RE: [llvm] r188807 - Marking MCJIT PIC tests as XFAIL on arm

Hi,

Thanks for doing this: however, it looks like the problem in two of the cases is that the aarch64 got added at a different point to the arm marking:
I don't care if they go at the beginning or end of the list (which doesn't look sorted) but it probably makes sense to keep them together.

Cheers,
Dave

--- llvm/trunk/test/ExecutionEngine/MCJIT/eh-lg-pic.ll (original) -; XFAIL: arm, cygwin, win32, mingw, mips, powerpc64, i686, i386, aarch64
+; XFAIL: arm, cygwin, win32, mingw, mips, powerpc64, i686, i386, 
+aarch64,
arm

--- llvm/trunk/test/ExecutionEngine/MCJIT/eh-sm-pic.ll (original) -; XFAIL: arm, cygwin, win32, mingw, mips, i686, i386, darwin, aarch64
+; XFAIL: arm, cygwin, win32, mingw, mips, i686, i386, darwin, aarch64, 
+arm







More information about the llvm-commits mailing list