[PATCH] Prevent generation of deprecated IT blocks in thumbv8

Tim Northover t.p.northover at gmail.com
Tue Aug 20 03:56:43 PDT 2013


Hi Artyom,

> The attached patch for the ARM backend implements this change in the
> predicability of Thumb instructions.

It looks like there are three patches in there.

The changes to IfConversion.cpp look like they're independent of
v8ness, and should probably be committed separately, with their own
justification. I confess I can't quite see through the logic there so
it would be useful to have examples (e.g. the tests) of just what it
changes.

Similarly the FastISel change doesn't directly refer to v8 so it'll
affect normal codegen in some way. It would be better to separate that
off.

Other than that, the changes look reasonable to me.

Cheers.

Tim.



More information about the llvm-commits mailing list