[llvm] r188768 - [stackprotector] Removed stale TODO.

Michael Gottesman mgottesman at apple.com
Tue Aug 20 01:46:13 PDT 2013


Author: mgottesman
Date: Tue Aug 20 03:46:13 2013
New Revision: 188768

URL: http://llvm.org/viewvc/llvm-project?rev=188768&view=rev
Log:
[stackprotector] Removed stale TODO.

Modified:
    llvm/trunk/lib/CodeGen/StackProtector.cpp

Modified: llvm/trunk/lib/CodeGen/StackProtector.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/StackProtector.cpp?rev=188768&r1=188767&r2=188768&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/StackProtector.cpp (original)
+++ llvm/trunk/lib/CodeGen/StackProtector.cpp Tue Aug 20 03:46:13 2013
@@ -397,8 +397,6 @@ bool StackProtector::InsertStackProtecto
                                           StackGuardVar);
     }    
 
-    // TODO: Put in check here if platform supports the stack protector check
-    // intrinsic.
     if (EnableSelectionDAGSP && !TM->Options.EnableFastISel &&
         SupportsSelectionDAGSP) {
       // Since we have a potential tail call, insert the special stack check
@@ -420,10 +418,9 @@ bool StackProtector::InsertStackProtecto
       CallInst::Create(Intrinsic, Args, "", InsertionPt);
 
     } else {
-      // If we do not have a potential tail call or our platform does not
-      // support lowering the stack protector check pseudo node, perform the IR
-      // level stack check.
-      
+      // If we do not support SelectionDAG based tail calls, generate IR level
+      // tail calls.
+      //
       // For each block with a return instruction, convert this:
       //
       //   return:





More information about the llvm-commits mailing list