[PATCH] - Improve widening of 3 element binary vector operations that don't trap

Nadav Rotem nrotem at apple.com
Mon Aug 19 12:04:54 PDT 2013


On Aug 19, 2013, at 11:30 AM, Redmond, Paul <paul.redmond at intel.com> wrote:

> Hi Nadav,
> 
> On 2013-08-19 1:00 PM, "Nadav Rotem" <nrotem at apple.com> wrote:
> 
>> Hi Paul, 
>> 
>> This patch looks good, but I am a little worried about denormals.  With
>> this patch we will execute vector operations on garbage at the fourth
>> vector element.  One possible solution would be to mask out the last
>> element. Does that sound right to you ?
> 
> That's a good question. I don't have a good answer right now. What about
> handling the floating point operations in WidenVecRes_BinaryCanTrap for
> now? (only the integral types are widened)
> 

I am okay with this solution. 

Thanks,
Nadav



More information about the llvm-commits mailing list