[llvm] r188605 - PR 16899: Do not modify the basic block using the iterator, but keep the

Joerg Sonnenberger joerg at britannica.bec.de
Sat Aug 17 04:10:03 PDT 2013


On Sat, Aug 17, 2013 at 11:04:49AM -0000, Joerg Sonnenberger wrote:
> Author: joerg
> Date: Sat Aug 17 06:04:47 2013
> New Revision: 188605
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=188605&view=rev
> Log:
> PR 16899: Do not modify the basic block using the iterator, but keep the
> next value. This avoids crashes due to invalidation.
> 
> Patch by Joey Gouly.

I'm aware that this is missing a test case. The IR for the original
reduced crasher can be found in the PR, but so far we haven't managed to
reproduce it with opt, only clang. As this prevents me from given SLP
more exposure in NetBSD and pkgsrc, I have opted for getting the fix in
first.

Joerg



More information about the llvm-commits mailing list