[PATCH] CMake: add LLVM_INSTALL_DEV_FILES variable

Hans Wennborg hans at chromium.org
Fri Aug 16 16:49:15 PDT 2013


  > Er, no?

  OK, I've changed it.

  > So, first note that this changes users of 'make install' in addition to users of cpack.

  Right. I think my patch description actually only mentioned the 'install' target, because I don't think a lot of folks use cpack. Anyway, I'll expand the commit message that it affects both.

  > There are two layers of this:
  >
  > 1) install development tools / resources useful for developing other *LLVM* projects (tblgen, etc)
  >
  > 2) install *anything* but executable binaries.
  >
  > I think these should be different. I think #1 should be default-off and turned on for users of the stand-alone Clang cmake build. It should be called something about "development".
  >
  > I think #2 should be default-on, because many many users of LLVM specifically want the core libraries. I think the best way is to negate the flag: make it INSTALL_TOOLCHAIN_BINARIES_ONLY or something, and when enabled, you only get the binaries used as part of a toolchain (llvm-{ar,nm,dwarfdump,...}, clang, clang-format, etc., but not opt or llc.

  I don't think I'm following. You say #1 and #2 should be different. If #1 is development tools and resources (i.e. tablegen, headers and libraries), doesn't that overlap with #2 being anything but toolchain binaries?

  I think my patch provides an good way to configure the install target. Currently, 'make install'  installs everything. I don't want to change that default. My patch just adds the possibility to exclude the "dev stuff", i.e. the libraries and headers. Isn't that pretty intuitive?

http://llvm-reviews.chandlerc.com/D1428



More information about the llvm-commits mailing list