[PATCH][PowerPC] More refactoring prior to real PPC emitPrologue()/emitEpilogue() changes

[Hal Finkel]

Mark,

I'll look at this in more detail, but just a quick note: Please remove the underscores from the variable names.

Thanks again,
Hal

----- Original Message -----
> 
> 
> 
> 
> This is a continuation of the refactorings performed in svn rev
> 188573 (see that rev's comments for more detail).
> 
> 
> 
> This is my stage 2 refactoring: I combined the emitPrologue() &
> emitEpilogue() PPC32 & PPC64 code into a single flow, simplifying a
> lot of the code since in essence the PPC32 & PPC64 code generation
> logic is the same, only the instruction forms are different (in most
> cases). This simplification is necessary because my functional
> changes (yet to come) add significant complexity, and without the
> simplification of my stage 2 refactoring, the overall complexity of
> both emitPrologue() & emitEpilogue() would have become almost
> intractable for most mortal programmers (like me).
> 
> 
> 
> This submission was intended to be a pure refactoring (no functional
> changes whatsoever). However, in the process of combining the PPC32
> & PPC64 flows, I spotted a difference that I believe is a bug (see
> svn rev 186478 line 863, or svn rev 188573 line 888): This line
> appears to be restoring the BP with the original FP content, not the
> original BP content. When I merged the 32-bit and 64-bit code, I
> used the corresponding code from the 64-bit flow, which I believe
> uses the correct offset (BPOffset) for this operation.
> 
> 
> 
> http://llvm-reviews.chandlerc.com/D1430
> 
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory