[PATCH} [Review Request] MCJIT PIC support for x86-64

Eli Bendersky eliben at google.com
Fri Aug 16 14:56:28 PDT 2013


On Fri, Aug 16, 2013 at 11:40 AM, Kaylor, Andrew <andrew.kaylor at intel.com>wrote:

>  Hi Eli,****
>
> ** **
>
> Thanks for the suggestions regarding documentation.  I’ll see what I can
> put together.  I believe I still have the diagrams you referred to, and I
> can put together something more to describe the control flow.****
>
> ** **
>
> BTW, I wanted to let you know that your old blog posts describing the PIC
> relocation model were extremely helpful as I was putting this patch
> together.  Yours was the clearest description of PIC handling that I was
> able to find.
>

Glad it helped! I'll have to reread them myself before I review your patch
;-)


> ****
>
> ** **
>
> Also, I meant to ask what ever happened to the lit subtest patch that you
> submitted about a year and a half ago.  As far as I can tell it was never
> committed, but I couldn’t tell why not.  The “new” tests I’m introducing
> are just duplications of other tests with variations in invocation
> arguments.  It would be nice to be able to simplify that ExecutionEngine
> testing tree.
>

I recall the patch was very close to being done, and Daniel Dunbar was OK
with it, but somehow in the last stages of reviewing we both got
distracted. The real problem is that the last versions of the patch were
mailed directly to Daniel from... my old @intel.com address. So unless
Daniel (CCd) still has them lying somewhere, I fear the patch is lost :-/
Not that it was a big deal, and it would have to be tweaked in light of the
recent additions to FileCheck anyhow. I still believe it's a good thing to
have and will be happy to help reviewing a new patch if anyone is willing
to take it over.

Eli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130816/f9fc5fad/attachment.html>


More information about the llvm-commits mailing list