[PATCH] [dfsan] Initial set of custom functions and interceptors for libc.

Evgeniy Stepanov eugenis at google.com
Thu Aug 15 04:49:52 PDT 2013


  Looks fine.


================
Comment at: lib/dfsan/dfsan_custom.cc:21
@@ +20,3 @@
+#include <ctype.h>
+#include <dlfcn.h>
+#include <stdlib.h>
----------------
Peter Collingbourne wrote:
> Evgeniy Stepanov wrote:
> > Alexey Samsonov wrote:
> > > We try to avoid including system headers in sanitizer tools, is probability an issue for dfsan?
> > It must be less of an issue for dfsan, because it does not have that many interceptors.
> > Custom functions do not need to (and, in fact, can not) match system header signature exactly.
> If the issue for interceptors is that they redeclare functions which may be macros in the headers, then it won't be an issue for the reasons eugenis mentioned.  If the issue is cross compilation, dfsan doesn't support that yet but I suspect the solution would be to fill in the headers in the SDKs directory.
I think there was an issue with strchr or something similar having different signatures depending on glibc version - const char * vs char *.


http://llvm-reviews.chandlerc.com/D1397



More information about the llvm-commits mailing list