[PATCH] DataFlowSanitizer: Add a debugging feature to help us track nonzero labels.

Evgeniy Stepanov eugenis at google.com
Thu Aug 15 04:41:31 PDT 2013


  LGTM


================
Comment at: lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:590
@@ +589,3 @@
+        else
+          Pos = DFSF.F->getEntryBlock().begin();
+        while (isa<PHINode>(Pos) || isa<AllocaInst>(Pos))
----------------
Looks like this is only possible when (*i) is an Argument, right?
Consider adding a self-documenting assert() check.


http://llvm-reviews.chandlerc.com/D1405

BRANCH
  dfsan-up6

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list