[PATCH] Add Cortex-A9 scheduling classes for vldm/vstm instructions that access more than 32 bytes

[Silviu Baranga]

Ok, that makes sense. I've added the CHECK lines.

Cheers,
Silviu

From: Renato Golin [mailto:renato.golin at linaro.org]
Sent: 14 August 2013 22:35
To: Silviu Baranga
Cc: Commit Messages and Patches for LLVM
Subject: Re: [PATCH] Add Cortex-A9 scheduling classes for vldm/vstm instructions that access more than 32 bytes

On 14 August 2013 22:31, Silviu Baranga <Silviu.Baranga at arm.com<mailto:Silviu.Baranga at arm.com>> wrote:
I think the test would be easily breakable if I would add those checks.
The vldm/vstm instructions were generated from fills/spills, so they might go away in the future or get replaced by some other code sequence.

So, I thought about that, and this is primarily why I think you *should* put the checks there.

My point is that, on the day it gets out, this test will be irrelevant to the feature in question, and will be wasting test time for nothing.

If you leave enough comments on the test to that regard, and put the CHECKs in place, whoever changes LLVM so that the vldm/vstm instructions won't be generated, will have the conscious decision to remove the test altogether.

cheers,
--renato

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130815/4b94c4d4/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: A9SchedLDM.diff
Type: application/octet-stream
Size: 25565 bytes
Desc: A9SchedLDM.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130815/4b94c4d4/attachment.obj>