[PATCH] Add Cortex-A9 scheduling classes for vldm/vstm instructions that access more than 32 bytes

Silviu Baranga Silviu.Baranga at arm.com
Wed Aug 14 14:31:16 PDT 2013


Hi Renato,

I think the test would be easily breakable if I would add those checks.
The vldm/vstm instructions were generated from fills/spills, so they might go away in the future or get replaced by some other code sequence.

However, if you feel strongly about this, I can add the CHECK lines.

Cheers,
Silviu
________________________________________
From: llvm-commits-bounces at cs.uiuc.edu [llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Renato Golin [renato.golin at linaro.org]
Sent: 14 August 2013 20:02
To: Silviu Baranga
Cc: Commit Messages and Patches for LLVM
Subject: Re: [PATCH] Add Cortex-A9 scheduling classes for vldm/vstm     instructions that access more than 32 bytes

On 14 August 2013 18:01, Silviu Baranga <Silviu.Baranga at arm.com<mailto:Silviu.Baranga at arm.com>> wrote:
The compiler asserts in the scheduling phase when trying to schedule vstm/vldm
instructions that access more than 32 bytes of memory. This is because it cannot
match any scheduling class for these instructions.

Hi Silviu,

I'm not a TableGen expert, but your patch looks good. Others might have better comments.

I know it's a pass/fail test, but would be good to add some CHECK lines to make sure the vldm/vstm are being generated.

cheers,
--renato

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2548782





More information about the llvm-commits mailing list