[PATCH] Allow for the use of StringRef command line options instead of cl::opt<std::string>

[Chris Lattner]

On Aug 13, 2013, at 9:55 AM, Puyan Lotfi <plotfi at apple.com> wrote:

> Oops, forgot to reattach the patch file.

I like this a lot, this seems like clearly the right way to go.  One concern: "ParseCommandLineOptions" is most commonly called on argc/argv coming into main, but that isn't always the case.  Clang for example, turns the -mllvm options into an an array and parses them (see clang/lib/FrontendTool/ExecuteCompilerInvocation.cpp and clang/lib/CodeGen/BackendUtil.cpp).

In this case, what keeps the memory from being deallocated underneath the StringRefs?

-Chris