[PATCH] Add ALL to FileCheck

Stephen Lin swlin at post.harvard.edu
Wed Aug 14 09:01:37 PDT 2013


> Hi Dmitri,
>
> I interpreted multiple prefixes as "match any on a single run", not as "pass
> multiple times, matching each individually".
>
> I think multi-pass is a different feature, unrelated to the ALL issue that
> Matt was implementing in the first place.
>
> I've added an enhancement (http://llvm.org/bugs/show_bug.cgi?id=16870) to
> FileCheck with something unrelated, too. I encourage you to do the same. ;)
>
> cheers,
> --renato

I agree with Renato here that multi-pass is a different feature. It's
arguable whether you would prefer multi-pass with separate prefixes or
one pass with multiple prefixes matching; you can come up with valid
use cases for either behavior. However, I think the later is more
intuitive as the default implementation of multiple prefixes, and is
also considerably simpler in implementation from what I remember of
FileCheck internals.

Stephen



More information about the llvm-commits mailing list