[PATCH] [dfsan] Initial set of custom functions and interceptors for libc.
Alexey Samsonov
samsonov at google.com
Wed Aug 14 00:05:10 PDT 2013
================
Comment at: lib/dfsan/CMakeLists.txt:33
@@ -30,3 +32,3 @@
SOURCES ${CLANG_RESOURCE_DIR}/dfsan_abilist.txt)
add_custom_command(OUTPUT ${CLANG_RESOURCE_DIR}/dfsan_abilist.txt
VERBATIM
----------------
Note that this file won't be copied anywhere when you run "make install". Probably you should do smth. similar (or somehow reuse) add_compiler_rt_resource_file CMake macro.
================
Comment at: lib/dfsan/CMakeLists.txt:7
@@ +6,3 @@
+ dfsan_custom.cc
+ dfsan_interceptors.cc
+ )
----------------
Let's keep closing parethesis on the same line
================
Comment at: lib/dfsan/dfsan_custom.cc:21
@@ +20,3 @@
+#include <ctype.h>
+#include <dlfcn.h>
+#include <stdlib.h>
----------------
We try to avoid including system headers in sanitizer tools, is probability an issue for dfsan?
http://llvm-reviews.chandlerc.com/D1397
More information about the llvm-commits
mailing list