[PATCH] Add ALL to FileCheck

Stephen Lin swlin at post.harvard.edu
Tue Aug 13 21:37:45 PDT 2013


I'm not sure there's a reasonable way to implement
--check-all-prefixes and not match things you don't want to match but
that happen to fit the form of a check line. Also, I'm not sure what
value that would have over just the option of using a preset list of
prefixes--is there really a case you would want every possible prefix
to match and it wouldn't be just as easy to provide the list of the
prefixes you expect explicitly? The list should not be very large for
any reasonable case I can think of.

-Stephen

On Tue, Aug 13, 2013 at 9:25 PM, Ron Ofir <ron.ofir at gmail.com> wrote:
> How about adding a new command line option --check-all-prefixes in addition
> to allowing multiple prefixes? That would allow to write tests that check
> for the default prefix, tests that check for multiple prefixes and tests
> that check everything.
>
> On Aug 14, 2013 5:41 AM, "Matt Arsenault" <arsenm2 at gmail.com> wrote:
>>
>>
>> On Aug 13, 2013, at 9:29 , Renato Golin <renato.golin at linaro.org> wrote:
>>
>> On 13 August 2013 17:11, Stephen Lin <swlin at post.harvard.edu> wrote:
>>>
>>> Exactly, my suggestion is for multiple prefixes only, and not ALL or
>>> any other prefix that is turned on in all cases. Only "CHECK" is
>>> grandfathered is as an implicit prefix, and it is only used in the
>>> case that no other prefix is provided.
>>
>>
>> Ok, that makes sense. I think I prefer this way, too.
>>
>> Matt, do you have any views on this? Anyone else?
>>
>>
>> I think the multiple -check-prefix option makes sense. I'll try doing that
>> later today
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list