[Mesa-dev] Patches: R600/SI: Rework resource descriptor types and fix piglit compute hangs

[Michel Dänzer]

On Mon, 2013-08-12 at 12:53 -0700, Tom Stellard wrote:
> Hi,
> 
> The attached patches make the v1i32 type which was used for sample
> coordinates and the v16i8 type which was used for resource descriptors
> illegal.  There is a new pass which will convert v1i32 to i32 and v16i8
> to i128 for all non-compute shaders.
> 
> Since v16i8 is a legal type in OpenCL, using this type for resource
> descriptors and making it legal was over-complicating the type legalizer
> and causing some piglit tests to hang.
> 
> The v1i32 type is identical to i32 on R600 and there is really no benefit
> in having it be a legal type.

I currently get 231 piglit failures from quick-driver.tests on SI, so it
would be quite an achievement for patch 3 to fix 364 piglit tests. ;)
Please fix / clarify that paragraph of the commit log.

In patch 5, it would be better to reference the URL of the bug report
itself instead of a bug attachment. And you can verify using llc and the
IR in the attachment that the bug is fixed.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer