[llvm] r187819 - Change private functions of LTOCodeGenerator from ret-false-on-succ to ret-true-on-succ.

[Eric Christopher]

Ping?

-eric

On Thu, Aug 8, 2013 at 1:07 PM, Eric Christopher <echristo at gmail.com> wrote:
>> As to consistency. Yes, consistency is important. That is why I need to
>> change
>> the interface.  On the other hand, maybe I were not clear before. What I
>> commit
>> in this revision only change the private functions. I'm working on the two
>> public functions
>> as well.
>>
>> As to documentation, in yesterday's commit. I clearly high-light the
>> return-on-false
>>
>
> My complaint here is that your patch changed the return of numerous
> functions without seemingly needing a documentation change. My request
> was that either a) you should have changed the documentation, or b) if
> it doesn't exist add some documentation to all of the functions you
> just changed stating what the expected return is.
>
> Thanks.
>
> -eric