[llvm] r188103 - Mark obviously const methods. Also use reference for parameters when possible.

[Kostya Serebryany]

thanks!


On Sat, Aug 10, 2013 at 12:53 AM, Jakub Staszak <kubastaszak at gmail.com>wrote:

> Author: kuba
> Date: Fri Aug  9 15:53:48 2013
> New Revision: 188103
>
> URL: http://llvm.org/viewvc/llvm-project?rev=188103&view=rev
> Log:
> Mark obviously const methods. Also use reference for parameters when
> possible.
>
> Modified:
>     llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
>
> Modified: llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=188103&r1=188102&r2=188103&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
> (original)
> +++ llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp Fri Aug
>  9 15:53:48 2013
> @@ -488,7 +488,7 @@ struct FunctionStackPoisoner : public In
>    void initializeCallbacks(Module &M);
>
>    // Check if we want (and can) handle this alloca.
> -  bool isInterestingAlloca(AllocaInst &AI) {
> +  bool isInterestingAlloca(AllocaInst &AI) const {
>      return (!AI.isArrayAllocation() &&
>              AI.isStaticAlloca() &&
>              AI.getAlignment() <= RedzoneSize() &&
> @@ -498,24 +498,24 @@ struct FunctionStackPoisoner : public In
>    size_t RedzoneSize() const {
>      return RedzoneSizeForScale(Mapping.Scale);
>    }
> -  uint64_t getAllocaSizeInBytes(AllocaInst *AI) {
> +  uint64_t getAllocaSizeInBytes(AllocaInst *AI) const {
>      Type *Ty = AI->getAllocatedType();
>      uint64_t SizeInBytes = ASan.TD->getTypeAllocSize(Ty);
>      return SizeInBytes;
>    }
> -  uint64_t getAlignedSize(uint64_t SizeInBytes) {
> +  uint64_t getAlignedSize(uint64_t SizeInBytes) const {
>      size_t RZ = RedzoneSize();
>      return ((SizeInBytes + RZ - 1) / RZ) * RZ;
>    }
> -  uint64_t getAlignedAllocaSize(AllocaInst *AI) {
> +  uint64_t getAlignedAllocaSize(AllocaInst *AI) const {
>      uint64_t SizeInBytes = getAllocaSizeInBytes(AI);
>      return getAlignedSize(SizeInBytes);
>    }
>    /// Finds alloca where the value comes from.
>    AllocaInst *findAllocaForValue(Value *V);
> -  void poisonRedZones(const ArrayRef<AllocaInst*> &AllocaVec, IRBuilder<>
> IRB,
> +  void poisonRedZones(const ArrayRef<AllocaInst*> &AllocaVec, IRBuilder<>
> &IRB,
>                        Value *ShadowBase, bool DoPoison);
> -  void poisonAlloca(Value *V, uint64_t Size, IRBuilder<> IRB, bool
> DoPoison);
> +  void poisonAlloca(Value *V, uint64_t Size, IRBuilder<> &IRB, bool
> DoPoison);
>  };
>
>  }  // namespace
> @@ -1283,7 +1283,7 @@ void FunctionStackPoisoner::initializeCa
>  }
>
>  void FunctionStackPoisoner::poisonRedZones(
> -  const ArrayRef<AllocaInst*> &AllocaVec, IRBuilder<> IRB, Value
> *ShadowBase,
> +  const ArrayRef<AllocaInst*> &AllocaVec, IRBuilder<> &IRB, Value
> *ShadowBase,
>    bool DoPoison) {
>    size_t ShadowRZSize = RedzoneSize() >> Mapping.Scale;
>    assert(ShadowRZSize >= 1 && ShadowRZSize <= 4);
> @@ -1460,7 +1460,7 @@ void FunctionStackPoisoner::poisonStack(
>  }
>
>  void FunctionStackPoisoner::poisonAlloca(Value *V, uint64_t Size,
> -                                         IRBuilder<> IRB, bool DoPoison) {
> +                                         IRBuilder<> &IRB, bool DoPoison)
> {
>    // For now just insert the call to ASan runtime.
>    Value *AddrArg = IRB.CreatePointerCast(V, IntptrTy);
>    Value *SizeArg = ConstantInt::get(IntptrTy, Size);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130812/cf45ea09/attachment.html>