[llvm] r188119 - Kill some duplicated code for removing unreachable BBs.

[Arnold Schwaighofer]

Okay.

I have reverted commit r188119 in the meantime in commit r188142 as it is breaking our bots.

Instructions:

Checkout llvm/clang.

A breaking version was:
llvm:  master
d080fb103fdc18c4e4b8977fd3fb4e0eef18adcf
svn: 188140
clang: master
30d237556fdd29b5075c990da953116225b95d9d
svn: 188139

$ cd llvm ; mkdir release ; cd release
$ ../configure --enable-optimized —prefix=$PWD/install
$ make
$ make check
$ Release+Asserts/bin/llvm-lit -v --param use_gmalloc=1 --param gmalloc_path=/usr/lib/libgmalloc.dylib ..//test/Instrumentation/DataFlowSanitizer/args-unreachable-bb.ll

Thanks,
Arnold

On Aug 10, 2013, at 3:02 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:

> Arnold,
> 
> This will have to wait until Monday when I will have access to a Mac.
> In the meantime can you please send me instructions for reproducing
> this?
> 
> Thanks,
> Peter
> 
> On Sat, Aug 10, 2013 at 02:52:23PM -0500, Arnold Schwaighofer wrote:
>> Hi Peter,
>> 
>> we run our tests with libgmalloc enabled on our internal buildbots. Following this commit (188119) the args-unreachable-bb.ll test fails:
>> 
>> Can you please fix this?
>> 
>> Thanks,
>> Arnold
> 
> -- 
> Peter