[PATCH] Fix assembling of Thumb2 branch instructions.
Tim Northover
t.p.northover at gmail.com
Fri Aug 9 02:49:50 PDT 2013
On 9 August 2013 10:08, Mihail Popa <mihail.popa at gmail.com> wrote:
> respectful ping
Very sorry, I started looking at it the other day but got distracted.
Two very minor nits. I'm happy for you to commit after fixing them:
+ default: assert(0 && "Unexpected instruction in cvtThumbBranches");
I think we prefer "llvm_unreachable(" instead of "assert(0 &&"
+ // now decide on encoding size besed on branch target range
Should be "based".
Cheers.
Tim.
More information about the llvm-commits
mailing list