[llvm] r187763 - Allow 4 as a valid debug info version.

[Benjamin Kramer]

On 07.08.2013, at 01:02, Eric Christopher <echristo at gmail.com> wrote:

> Absolutely, though admittedly I'd rather remove the function.
> 
> Benjamin: any reason it needs to exist?

This code was lifted from LLDB, I guess it's just trying to be defensive. Feel free to nuke it, I don't think there is any DWARF1 out there these days.

- Ben

> 
> -eric
> 
> On Mon, Aug 5, 2013 at 7:59 PM, Chandler Carruth <chandlerc at google.com> wrote:
>> Test case?
>> 
>> :: whistles innocently ::
>> 
>> 
>> On Mon, Aug 5, 2013 at 6:38 PM, Eric Christopher <echristo at gmail.com> wrote:
>>> 
>>> Author: echristo
>>> Date: Mon Aug  5 20:38:27 2013
>>> New Revision: 187763
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=187763&view=rev
>>> Log:
>>> Allow 4 as a valid debug info version.
>>> 
>>> Modified:
>>>    llvm/trunk/lib/DebugInfo/DWARFContext.h
>>> 
>>> Modified: llvm/trunk/lib/DebugInfo/DWARFContext.h
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFContext.h?rev=187763&r1=187762&r2=187763&view=diff
>>> 
>>> ==============================================================================
>>> --- llvm/trunk/lib/DebugInfo/DWARFContext.h (original)
>>> +++ llvm/trunk/lib/DebugInfo/DWARFContext.h Mon Aug  5 20:38:27 2013
>>> @@ -130,7 +130,7 @@ public:
>>>   virtual const RelocAddrMap &infoDWORelocMap() const = 0;
>>> 
>>>   static bool isSupportedVersion(unsigned version) {
>>> -    return version == 2 || version == 3;
>>> +    return version == 2 || version == 3 || version == 4;
>>>   }
>>> private:
>>>   /// Return the compile unit that includes an offset (relative to
>>> .debug_info).
>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>>