[llvm] r187819 - Change private functions of LTOCodeGenerator from ret-false-on-succ to ret-true-on-succ.

[Eric Christopher]

On Tue, Aug 6, 2013 at 3:37 PM, Shuxin Yang <shuxin.llvm at gmail.com> wrote:
>
>
>> To whom?
>
> To everybody who feel more natural with return-true-on-succ.

Then why aren't you proposing a standard for the project and changing
everything?

>
>
>> The code that you'd be changing hasn't been committed yet.
>>
> I don't think it is better to commit confusing integrated code first, then
> get rid of confusing part.

This isn't what I'm saying at all. I'm saying that you should change
the code that you're writing to match the code that you are
integrating with since your code hasn't been approved or committed
yet. Then, in the future, if we want to change the meaning of the APIs
all of it can change.

You should probably bother to document the returns for these functions
since you want to go through the effort of changing it as well.

-eric