[llvm] r187819 - Change private functions of LTOCodeGenerator from ret-false-on-succ to ret-true-on-succ.
Shuxin Yang
shuxin.llvm at gmail.com
Tue Aug 6 14:51:21 PDT 2013
Author: shuxin_yang
Date: Tue Aug 6 16:51:21 2013
New Revision: 187819
URL: http://llvm.org/viewvc/llvm-project?rev=187819&view=rev
Log:
Change private functions of LTOCodeGenerator from ret-false-on-succ to ret-true-on-succ.
Modified:
llvm/trunk/tools/lto/LTOCodeGenerator.cpp
Modified: llvm/trunk/tools/lto/LTOCodeGenerator.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lto/LTOCodeGenerator.cpp?rev=187819&r1=187818&r2=187819&view=diff
==============================================================================
--- llvm/trunk/tools/lto/LTOCodeGenerator.cpp (original)
+++ llvm/trunk/tools/lto/LTOCodeGenerator.cpp Tue Aug 6 16:51:21 2013
@@ -159,7 +159,7 @@ bool LTOCodeGenerator::setCodePICModel(l
bool LTOCodeGenerator::writeMergedModules(const char *path,
std::string &errMsg) {
- if (determineTarget(errMsg))
+ if (!determineTarget(errMsg))
return true;
// Run the verifier on the merged modules.
@@ -213,7 +213,7 @@ bool LTOCodeGenerator::compile_to_file(c
}
objFile.keep();
- if (genResult) {
+ if (!genResult) {
sys::fs::remove(Twine(Filename));
return true;
}
@@ -252,7 +252,7 @@ const void* LTOCodeGenerator::compile(si
bool LTOCodeGenerator::determineTarget(std::string &errMsg) {
if (_target != NULL)
- return false;
+ return true;
// if options were requested, set them
if (!_codegenOptions.empty())
@@ -267,7 +267,7 @@ bool LTOCodeGenerator::determineTarget(s
// create target machine from info for merged modules
const Target *march = TargetRegistry::lookupTarget(TripleStr, errMsg);
if (march == NULL)
- return true;
+ return false;
// The relocation model is actually a static member of TargetMachine and
// needs to be set before the TargetMachine is instantiated.
@@ -300,7 +300,7 @@ bool LTOCodeGenerator::determineTarget(s
_target = march->createTargetMachine(TripleStr, _mCpu, FeatureStr, Options,
RelocModel, CodeModel::Default,
CodeGenOpt::Aggressive);
- return false;
+ return true;
}
void LTOCodeGenerator::
@@ -391,8 +391,8 @@ void LTOCodeGenerator::applyScopeRestric
/// Optimize merged modules using various IPO passes
bool LTOCodeGenerator::generateObjectFile(raw_ostream &out,
std::string &errMsg) {
- if (this->determineTarget(errMsg))
- return true;
+ if (!this->determineTarget(errMsg))
+ return false;
Module* mergedModule = _linker.getModule();
@@ -435,7 +435,7 @@ bool LTOCodeGenerator::generateObjectFil
if (_target->addPassesToEmitFile(codeGenPasses, Out,
TargetMachine::CGFT_ObjectFile)) {
errMsg = "target file type not supported";
- return true;
+ return false;
}
// Run our queue of passes all at once now, efficiently.
@@ -444,7 +444,7 @@ bool LTOCodeGenerator::generateObjectFil
// Run the code generator, and write assembly file
codeGenPasses.run(*mergedModule);
- return false; // success
+ return true;
}
/// setCodeGenDebugOptions - Set codegen debugging options to aid in debugging
More information about the llvm-commits
mailing list