Re: [PATCH] pow(10, x) ―> __exp10(x)

[Hal Finkel]

----- Original Message -----
> Yi,
> 
> This seems like a good idea, but, I think that this needs to be
> guarded by a check on the target triple. __exp10 is Darwin specific?
> gnu systems have exp10 (and exp10f, exp10l), which are obviously
> also non-standard.
> 
> Also, personally, I'd prefer a patch with the normal amount of
> context (not everything).

One more thing:

                           Op1, "powrecip");
     return 0;
-  }
+  } 
 };

It looks like you're accidentally adding extra white-space.

 -Hal

> 
> Thanks,
> Hal
> 
> ----- Original Message -----
> > Hi,
> > 
> > In this patch, we try to transform  pow(10, x) to __exp10(x) since
> > __exp10(x) is much faster
> > 
> > 
> > Files:Utils/SimplifyLibCalls.cpp
> > 
> > .
> > 
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> > 
> 
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory