[PATCH] [FileCheck] Fix a bug that cause FileCheck to misidentify check-prefix

[Robinson, Paul]

Does this fix PR14812, by any chance?
http://llvm.org/bugs/show_bug.cgi?id=14812
--paulr

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Tim Northover
> Sent: Friday, August 02, 2013 12:56 PM
> To: reviews+D1271+public+9464cdd8fa4b7a8e at llvm-reviews.chandlerc.com
> Cc: llvm-commits
> Subject: Re: [PATCH] [FileCheck] Fix a bug that cause FileCheck to
> misidentify check-prefix
> 
> > The current behavior looks like a bug to me, but I'm not
> > 100% sure. With this patch, do all the existing tests pass?
> 
> I'd agree it's a bug (I hit it myself today, in fact), but haven't you
> checked existing tests before committing? If not you should definitely
> run "make check-all".
> 
> I'm a little concerned about the logic though. Does FileCheck normally
> consider A-z and 1-9 as its token range? 1-9 seems particularly odd
> (what about 0?) but A-z includes quite a few characters that aren't
> usually in tokens too.
> 
> Cheers.
> 
> Tim.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits